Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Wed, 8 Jun 2016 15:50:20 +0000 (UTC)
From: "Oleg Zhurakousky (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.12853043.1438977595000.28452.1465401020979@Atlassian.JIRA>
In-Reply-To: <JIRA.12853043.1438977595000@Atlassian.JIRA>
References: <JIRA.12853043.1438977595000@Atlassian.JIRA> <JIRA.12853043.1438977595579@arcas>
Subject: [jira] [Commented] (NIFI-826) Export templates in a deterministic
 way
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 08 Jun 2016 15:50:22 -0000


    [ https://issues.apache.org/jira/browse/NIFI-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320786#comment-15320786 ] 

Oleg Zhurakousky commented on NIFI-826:
---------------------------------------

Just continuing with some relevant notes:
After initial prototyping the _inceptionId_ approach seem to work, although I don't like the fact that we must have _public void setInceptionId(String inceptionId)_ to make JAXB to work. Basically it's needed for de-serialization purposes but I want to make sure that it is not called by anyone/anything else, so the workaround I am experimenting with now is something like this:
{code}
StackTraceElement element = Thread.currentThread().getStackTrace()[2];
if (element.getClassName().endsWith("getInceptionId_setInceptionId_java_lang_String")) {
     this.inceptionId = UUID.fromString(inceptionId);
} else {
     throw new RuntimeException("Setting inception id is not allowed since it is generated and immutable.");
}
{code}
Basically, analyze the stack trace and see if it's called by the appropriate component (JAXB in this case)

> Export templates in a deterministic way
> ---------------------------------------
>
>                 Key: NIFI-826
>                 URL: https://issues.apache.org/jira/browse/NIFI-826
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Matt Gilman
>            Assignee: Oleg Zhurakousky
>             Fix For: 1.0.0
>
>
> Templates should be exported in a deterministic way so that they can be compared or diff'ed with another. Items to consider...
> - The ordering of components
> - The id's used to identify the components
> - Consider excluding irrelevant items. When components are imported some settings are ignored (run state).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)