nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1919) Expression Language only evaluates regular expression replacement on replaceAll, not replace
Date Wed, 01 Jun 2016 15:36:59 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310491#comment-15310491
] 

ASF GitHub Bot commented on NIFI-1919:
--------------------------------------

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/474
  
    Please just make sure we don't create problems for old flows.  Can change names if we
have a smooth transition for existing EL statements. 


> Expression Language only evaluates regular expression replacement on replaceAll, not
replace
> --------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1919
>                 URL: https://issues.apache.org/jira/browse/NIFI-1919
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 0.6.1
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>             Fix For: 1.0.0, 0.7.0
>
>
> When {{${attribute:replaceAll('\w+', 'replacement')}}} is called, the pattern is matched
and applied. However, when {{${attribute:replace('\w+', 'replacement')}}} is called, it is
not. I believe this is because {{ReplaceAllEvaluator}} uses {{String#replaceAll(String regex,
String replacement)}} while {{ReplaceEvaluator}} uses {{String#replace(CharSequence target,
CharSequence replacement)}} which then uses {{Pattern.compile(target.toString(), Pattern.LITERAL)}}
instead of compiling for a regular expression. I am writing a unit test to demonstrate this
and show the results when {{String#replaceFirst()}} is used instead. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message