nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1838) Groovy Test Scripts will require refactoring if we implement NIFI-1152
Date Tue, 21 Jun 2016 23:17:57 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343011#comment-15343011
] 

ASF GitHub Bot commented on NIFI-1838:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/534#discussion_r67970007
  
    --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
---
    @@ -92,11 +92,10 @@
                         logger.error(message, t);
                     }
                 }
    -        } else {
    -            // Return defaults for now
    -            relationships.add(REL_SUCCESS);
    -            relationships.add(REL_FAILURE);
             }
    +        // Add defaults
    +        relationships.add(REL_SUCCESS);
    +        relationships.add(REL_FAILURE);
    --- End diff --
    
    Yeah if this is failing tests, I'd say take a look at the tests. We don't want to add
default relationships, especially when there's a legit instance of a Processor, as it is the
Processor's responsibility to define all relationships


> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> ----------------------------------------------------------------------
>
>                 Key: NIFI-1838
>                 URL: https://issues.apache.org/jira/browse/NIFI-1838
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0, 0.6.1
>            Reporter: Puspendu Banerjee
>              Labels: patch
>             Fix For: 1.0.0
>
>         Attachments: 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they don't define
Relationships properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message