Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Wed, 11 May 2016 01:24:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.12921089.1449850087000.160513.1462929852847@Atlassian.JIRA>
In-Reply-To: <JIRA.12921089.1449850087000@Atlassian.JIRA>
References: <JIRA.12921089.1449850087000@Atlassian.JIRA> <JIRA.12921089.1449850087570@arcas>
Subject: [jira] [Commented] (NIFI-1280) Create FilterCSVColumns Processor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 11 May 2016 01:24:14 -0000


    [ https://issues.apache.org/jira/browse/NIFI-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279350#comment-15279350 ] 

ASF GitHub Bot commented on NIFI-1280:
--------------------------------------

Github user zinking commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/420#discussion_r62780338
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/calcite/adapter/csv/CsvEnumerator2.java ---
    @@ -0,0 +1,303 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.calcite.adapter.csv;
    +
    +import java.io.IOException;
    +import java.text.ParseException;
    +import java.util.ArrayList;
    +import java.util.Date;
    +import java.util.List;
    +import java.util.TimeZone;
    +
    +import org.apache.calcite.adapter.java.JavaTypeFactory;
    +import org.apache.calcite.linq4j.Enumerator;
    +import org.apache.calcite.rel.type.RelDataType;
    +import org.apache.calcite.util.Pair;
    +import org.apache.commons.lang3.time.FastDateFormat;
    +
    +import au.com.bytecode.opencsv.CSVReader;
    +
    +
    +/** Enumerator that reads from a CSV stream.
    + *
    + * @param <E> Row type
    + */
    +class CsvEnumerator2<E> implements Enumerator<E> {
    --- End diff --
    
    why CsvEnumerator2, isn't there a better name?


> Create FilterCSVColumns Processor
> ---------------------------------
>
>                 Key: NIFI-1280
>                 URL: https://issues.apache.org/jira/browse/NIFI-1280
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Toivo Adams
>
> We should have a Processor that allows users to easily filter out specific columns from CSV data. For instance, a user would configure two different properties: "Columns of Interest" (a comma-separated list of column indexes) and "Filtering Strategy" (Keep Only These Columns, Remove Only These Columns).
> We can do this today with ReplaceText, but it is far more difficult than it would be with this Processor, as the user has to use Regular Expressions, etc. with ReplaceText.
> Eventually a Custom UI could even be built that allows a user to upload a Sample CSV and choose which columns from there, similar to the way that Excel works when importing CSV by dragging and selecting the desired columns? That would certainly be a larger undertaking and would not need to be done for an initial implementation.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)