nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Zhurakousky (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1774) AbstractControllerService: use of deprecated Annotation
Date Wed, 04 May 2016 15:38:12 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270852#comment-15270852
] 

Oleg Zhurakousky commented on NIFI-1774:
----------------------------------------

So, this is actually not a bug. The @OnConfigured annotation (although deprecated) is used
to call methods every time configuration changes were made (see _StandardControllerServiceNode#onConfigured()_
method).
So, what is a bug is that while deprecated we have not created a new annotation to be used
in its place. So we need another JIRA to create a new annotation (e.g., @OnPropertyChanged,
@OnConfigurationChange etc.).
Anyway, I'll be closing this as no fix and will amend the PR to only address typo.

> AbstractControllerService: use of deprecated Annotation
> -------------------------------------------------------
>
>                 Key: NIFI-1774
>                 URL: https://issues.apache.org/jira/browse/NIFI-1774
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Brandon DeVries
>            Assignee: Pierre Villard
>            Priority: Trivial
>
> AbstractControllerService is using the deprecated annotation \@OnConfigured.  Possibly
should be org.apache.nifi.annotation.lifecycle.OnEnabled.
> https://github.com/apache/nifi/blob/e4b7e47836edf47042973e604005058c28eed23b/nifi-api/src/main/java/org/apache/nifi/controller/AbstractControllerService.java#L52



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message