nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1745) Refactor how NCM federates requests to nodes
Date Fri, 06 May 2016 19:23:12 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274592#comment-15274592
] 

ASF GitHub Bot commented on NIFI-1745:
--------------------------------------

Github user mcgilman commented on the pull request:

    https://github.com/apache/nifi/pull/413#issuecomment-217535825
  
    Turns out I had a deployment problem earlier... 
    
    Anyways, running great after the most recent update. I agree we need to introduce these
changes in stages given the number of moving parts. I've addressed a couple minor issues (URI
paths, .gitignore, etc) which I'll be including in your commit. 
    
    One suggestion for the next portion of this work would be to re-introduce the wiring of
the HTTP Replicator and Response Mapper in the WebClusterManager. While requiring more arguments,
this would ultimately help promote testability rather than hard-coding a particular implementation.



> Refactor how NCM federates requests to nodes
> --------------------------------------------
>
>                 Key: NIFI-1745
>                 URL: https://issues.apache.org/jira/browse/NIFI-1745
>             Project: Apache NiFi
>          Issue Type: Task
>    Affects Versions: 1.0.0
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.0.0
>
>
> Currently, all of the logic to federate requests exists within the WebClusterManager
class. This needs to be refactored into better encapsulated code so that the logic is more
easily moved to the nodes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message