Return-Path: 
 <commits-return-23935-apmail-nifi-commits-archive=nifi.apache.org@nifi.apache.org>
X-Original-To: apmail-nifi-commits-archive@minotaur.apache.org
Delivered-To: apmail-nifi-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CB720194CC
	for <apmail-nifi-commits-archive@minotaur.apache.org>;
 Mon, 18 Apr 2016 01:24:25 +0000 (UTC)
Received: (qmail 72127 invoked by uid 500); 18 Apr 2016 01:24:25 -0000
Delivered-To: apmail-nifi-commits-archive@nifi.apache.org
Received: (qmail 72097 invoked by uid 500); 18 Apr 2016 01:24:25 -0000
Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@nifi.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@nifi.apache.org>
List-Post: <mailto:commits@nifi.apache.org>
List-Id: <commits.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list commits@nifi.apache.org
Received: (qmail 72074 invoked by uid 99); 18 Apr 2016 01:24:25 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 01:24:25 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 7378B2C1F54
	for <commits@nifi.apache.org>; Mon, 18 Apr 2016 01:24:25 +0000 (UTC)
Date: Mon, 18 Apr 2016 01:24:25 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.12958579.1460575139000.251507.1460942665470@Atlassian.JIRA>
In-Reply-To: <JIRA.12958579.1460575139000@Atlassian.JIRA>
References: <JIRA.12958579.1460575139000@Atlassian.JIRA>
 <JIRA.12958579.1460575139540@arcas>
Subject: [jira] [Commented] (NIFI-1764) NullPointerException in PutKafka for
 failed segments with no delimiter and insufficient producer handling
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/NIFI-1764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245034#comment-15245034 ] 

ASF GitHub Bot commented on NIFI-1764:
--------------------------------------

Github user olegz commented on the pull request:

    https://github.com/apache/nifi/pull/350#issuecomment-211148835
  
    This is most likely a no-merge PR. There is some work that is currently being done by @joewitt and elements of this PR will already be there.


> NullPointerException in PutKafka for failed segments with no delimiter and insufficient producer handling
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1764
>                 URL: https://issues.apache.org/jira/browse/NIFI-1764
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.0.0, 0.7.0
>            Reporter: Christopher McDermott
>            Assignee: Joseph Witt
>              Labels: patch
>             Fix For: 1.0.0, 0.7.0
>
>
> This NPE can happen during certain failure cases and it appears to be related to the lack of guarding of the failed segments attribute addition in the case there is no delimiter.  Further, we have observed the PutKafka processor becoming ineffective if the established kafka client starts seeing failed acks/timeouts.  We need to catch those cases and teardown the old client and create a new one instead.
> {code}
> java.lang.NullPointerException: null
> at java.lang.String.<init>(String.java:503) ~[na:1.8.0_45]
> at org.apache.nifi.processors.kafka.PutKafka.buildFailedFlowFileAttributes(PutKafka.java:396) ~[na:na]
> at org.apache.nifi.processors.kafka.PutKafka.onTrigger(PutKafka.java:308) ~[na:na]
> at org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27) ~[nifi-api-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1059) ~[nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:136) [nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47) [nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:123) [nifi-framework-core-0.7.0-SNAPSHOT.jar:0.7.0-SNAPSHOT]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_45]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_45]
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_45]
> at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_45]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)