nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1636) Print entire stacktrace when unexpected exception occurs during onTrigger
Date Wed, 16 Mar 2016 21:35:33 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198228#comment-15198228
] 

ASF GitHub Bot commented on NIFI-1636:
--------------------------------------

Github user rickysaltzer commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/285#discussion_r56419796
  
    --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
    @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext context, final ProcessSessionFa
                 onTrigger(context, session);
                 session.commit();
             } catch (final Throwable t) {
    -            getLogger().error("{} failed to process due to {}; rolling back session",
new Object[]{this, t});
    +            StringWriter stacktraceWriter = new StringWriter();
    --- End diff --
    
    I wonder if it would make sense to surface the shorthand message to the user in the UI
but log the stacktrace to the log file. I imagine this would take some re-working. 


> Print entire stacktrace when unexpected exception occurs during onTrigger
> -------------------------------------------------------------------------
>
>                 Key: NIFI-1636
>                 URL: https://issues.apache.org/jira/browse/NIFI-1636
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>
> As of now the try/catch clause in the {{AbstractProcessor}} class doesn't print the entire
stacktrace when a processor throws an unexpected exception. 
> Printing the entire stacktrace comes especially in handy when users are creating custom
processors for internal use.
> The difference in information can be seen below:
> *Before*
> {code}
> java.lang.NumberFormatException: For input string: "five"
> {code}
> *After*
> {code}
> java.lang.NumberFormatException: For input string: "five"
> 	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> 	at java.lang.Integer.parseInt(Integer.java:580)
> 	at java.lang.Integer.parseInt(Integer.java:615)
> 	at TestException.main(TestException.java:5)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message