Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Mon, 1 Feb 2016 16:54:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.12856969.1439918264000.265663.1454345679912@Atlassian.JIRA>
In-Reply-To: <JIRA.12856969.1439918264000@Atlassian.JIRA>
References: <JIRA.12856969.1439918264000@Atlassian.JIRA>
 <JIRA.12856969.1439918264310@arcas>
Subject: [jira] [Commented] (NIFI-865) Add processors to Get and Put to/from
 AMQP-based messaging systems
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/NIFI-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126551#comment-15126551 ] 

ASF GitHub Bot commented on NIFI-865:
-------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/199#discussion_r51444798
  
    --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/resources/log4j.properties ---
    @@ -0,0 +1,22 @@
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +log4j.rootLogger=INFO, CONSOLE
    +
    +log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
    +
    +log4j.appender.CONSOLE.layout=org.apache.log4j.PatternLayout
    +log4j.appender.CONSOLE.layout.ConversionPattern=%-4r [%t] %-5p %c %x \u2013 %m%n
    +
    +log4j.logger.org.apache.flume = DEBUG
    --- End diff --
    
    I know this review (for now) is just for code, but I wanted to leave a note for files that are "functional" and not purely documentation, for the Flume references to be updated


> Add processors to Get and Put to/from AMQP-based messaging systems
> ------------------------------------------------------------------
>
>                 Key: NIFI-865
>                 URL: https://issues.apache.org/jira/browse/NIFI-865
>             Project: Apache NiFi
>          Issue Type: Wish
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Oleg Zhurakousky
>              Labels: beginner
>             Fix For: 0.5.0
>
>
> David Smith in the mailing list has already begun work on this.  The link to his current set of code in Github is here:  https://github.com/helicopterman22/nifi_amqp_processors
> He is seeking help with licensing/unit testing/etc.. so that it can end up in a build.
> We have word from another user now that they too are interested in this.  They specifically are using RabbitMQ but we should be able to implement (ideally) a pure AMQP protocol friendly version and be good to go.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)