nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1464) Refactor lifecycle code for Processors and other components
Date Mon, 15 Feb 2016 14:55:18 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147439#comment-15147439
] 

ASF GitHub Bot commented on NIFI-1464:
--------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/210#discussion_r52907459
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/service/TestStandardControllerServiceProvider.java
---
    @@ -218,7 +221,7 @@ public void testStartStopReferencingComponents() {
                 public Object answer(InvocationOnMock invocation) throws Throwable {
                     final ProcessorNode procNode = (ProcessorNode) invocation.getArguments()[0];
                     procNode.verifyCanStart();
    -                procNode.setScheduledState(ScheduledState.RUNNING);
    +                // procNode.setScheduledState(ScheduledState.RUNNING);
    --- End diff --
    
    True, and I think this test(s) may need to be removed since tests that I added as part
of the refactoring efforts cover all possible scenarios without Mocks. And if for some reason
you'll find a missing scenario, let me know and I'll add a test.


> Refactor lifecycle code for Processors and other components
> -----------------------------------------------------------
>
>                 Key: NIFI-1464
>                 URL: https://issues.apache.org/jira/browse/NIFI-1464
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.6.0
>
>
> Similar lifecycle handling improvements that went in as part of the NIFI-1164 for ControllerServices,
could/should be applied to other  components (e..g, Processors).
> The improvements may also help to address NIFI-78 (may be without killing the thread).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message