nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1464) Refactor lifecycle code for Processors and other components
Date Sun, 14 Feb 2016 00:25:18 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146281#comment-15146281
] 

ASF GitHub Bot commented on NIFI-1464:
--------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/210#discussion_r52835777
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/scheduling/StandardProcessScheduler.java
---
    @@ -288,171 +284,74 @@ public void run() {
         }
     
         /**
    -     * Starts scheduling the given processor to run after invoking all methods on the
underlying {@link org.apache.nifi.processor.Processor
    -     * FlowFileProcessor} that are annotated with the {@link OnScheduled} annotation.
    +     * Starts the given {@link Processor} by invoking its
    +     * {@link ProcessorNode#start(ScheduledExecutorService, long, org.apache.nifi.processor.ProcessContext,
Runnable)}
    +     * .
    +     * @see StandardProcessorNode#start(ScheduledExecutorService, long,
    +     *      org.apache.nifi.processor.ProcessContext, Runnable).
          */
         @Override
         public synchronized void startProcessor(final ProcessorNode procNode) {
    -        if (procNode.getScheduledState() == ScheduledState.DISABLED) {
    --- End diff --
    
    A bit confused as to where this went.  Stepped through the associated implementations
but not seeing any place where this is validated.  


> Refactor lifecycle code for Processors and other components
> -----------------------------------------------------------
>
>                 Key: NIFI-1464
>                 URL: https://issues.apache.org/jira/browse/NIFI-1464
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.6.0
>
>
> Similar lifecycle handling improvements that went in as part of the NIFI-1164 for ControllerServices,
could/should be applied to other  components (e..g, Processors).
> The improvements may also help to address NIFI-78 (may be without killing the thread).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message