nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1180) Modify PutS3Object to enable encryption
Date Sat, 27 Feb 2016 03:49:18 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170337#comment-15170337
] 

ASF GitHub Bot commented on NIFI-1180:
--------------------------------------

Github user adamonduty commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/246#discussion_r54327468
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
    @@ -177,10 +179,19 @@
                 .addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor SERVER_SIDE_ENCRYPTION = new PropertyDescriptor.Builder()
    +            .name("Server Side Encryption")
    --- End diff --
    
    That makes sense, but there are also 6 instances above this code that doesn't follow the
same rule. Which is best: match the existing style, or match the rule?


> Modify PutS3Object to enable encryption
> ---------------------------------------
>
>                 Key: NIFI-1180
>                 URL: https://issues.apache.org/jira/browse/NIFI-1180
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Elli Schwarz
>            Priority: Minor
>
> Amazon allows encryption to be enforced on objects that are put to S3. In the PutS3Object
class, the objectMetadata object contains a method setSSEAlgorithm which can set encryption
for the objects. A Nifi property should be added to the PutS3Object class so a user can enable/disable
encryption from the processor itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message