nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-865) Add processors to Get and Put to/from AMQP-based messaging systems
Date Tue, 02 Feb 2016 17:24:39 GMT

    [ https://issues.apache.org/jira/browse/NIFI-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128607#comment-15128607
] 

ASF GitHub Bot commented on NIFI-865:
-------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/200#discussion_r51602109
  
    --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java
---
    @@ -0,0 +1,104 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.amqp.processors;
    +
    +import java.io.IOException;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.rabbitmq.client.Channel;
    +import com.rabbitmq.client.Connection;
    +
    +/**
    + * Base class for implementing publishing and consuming AMQP workers.
    + *
    + * @see AMQPPublisher
    + * @see AMQPConsumer
    + */
    +abstract class AMQPWorker implements AutoCloseable {
    +
    +    private final static Logger logger = LoggerFactory.getLogger(AMQPWorker.class);
    +
    +    protected final Channel channel;
    +
    +    /**
    +     * Creates an instance of this worker initializing it with AMQP
    +     * {@link Connection} and creating a target {@link Channel} used by
    +     * sub-classes to interruct with AMQP-based messaging system.
    +     *
    +     * @param connection
    +     *            instance of {@link Connection}
    +     */
    +    public AMQPWorker(Connection connection) {
    +        this.validateConnection(connection);
    +        try {
    +            this.channel = connection.createChannel();
    +        } catch (IOException e) {
    +            logger.error("Failed to create Channel for " + connection, e);
    +            throw new IllegalStateException(e);
    +        }
    +    }
    +
    +    /**
    +     * Closes {@link Channel} created when instance of this class was created.
    +     */
    +    @Override
    +    public void close() throws Exception {
    --- End diff --
    
    That comes from AutoCloseable.


> Add processors to Get and Put to/from AMQP-based messaging systems
> ------------------------------------------------------------------
>
>                 Key: NIFI-865
>                 URL: https://issues.apache.org/jira/browse/NIFI-865
>             Project: Apache NiFi
>          Issue Type: Wish
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Oleg Zhurakousky
>              Labels: beginner
>             Fix For: 0.5.0
>
>
> David Smith in the mailing list has already begun work on this.  The link to his current
set of code in Github is here:  https://github.com/helicopterman22/nifi_amqp_processors
> He is seeking help with licensing/unit testing/etc.. so that it can end up in a build.
> We have word from another user now that they too are interested in this.  They specifically
are using RabbitMQ but we should be able to implement (ideally) a pure AMQP protocol friendly
version and be good to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message