nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-865) Add processors to Get and Put to/from AMQP-based messaging systems
Date Mon, 01 Feb 2016 16:47:40 GMT

    [ https://issues.apache.org/jira/browse/NIFI-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126531#comment-15126531
] 

ASF GitHub Bot commented on NIFI-865:
-------------------------------------

Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/199#discussion_r51443717
  
    --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPConsumer.java
---
    @@ -0,0 +1,78 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.amqp.processors;
    +
    +import java.io.IOException;
    +
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.rabbitmq.client.Channel;
    +import com.rabbitmq.client.Connection;
    +import com.rabbitmq.client.GetResponse;
    +
    +/**
    + * Generic consumer of messages from AMQP-based messaging system. It is based on
    + * RabbitMQ client API (https://www.rabbitmq.com/api-guide.html)
    + */
    +final class AMQPConsumer extends AMQPWorker {
    +
    +    private final static Logger logger = LoggerFactory.getLogger(AMQPConsumer.class);
    --- End diff --
    
    "IF" we do that we'll change it, but as you can see right now its very package private
;) 


> Add processors to Get and Put to/from AMQP-based messaging systems
> ------------------------------------------------------------------
>
>                 Key: NIFI-865
>                 URL: https://issues.apache.org/jira/browse/NIFI-865
>             Project: Apache NiFi
>          Issue Type: Wish
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Oleg Zhurakousky
>              Labels: beginner
>             Fix For: 0.5.0
>
>
> David Smith in the mailing list has already begun work on this.  The link to his current
set of code in Github is here:  https://github.com/helicopterman22/nifi_amqp_processors
> He is seeking help with licensing/unit testing/etc.. so that it can end up in a build.
> We have word from another user now that they too are interested in this.  They specifically
are using RabbitMQ but we should be able to implement (ideally) a pure AMQP protocol friendly
version and be good to go.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message