nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1317) StandardProcessorNode hides 'name' instance variable defined in AbstractConfiguredComponent
Date Wed, 13 Jan 2016 01:25:40 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095396#comment-15095396
] 

ASF GitHub Bot commented on NIFI-1317:
--------------------------------------

Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/169#discussion_r49541089
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java
---
    @@ -57,6 +57,7 @@ public AbstractConfiguredComponent(final ConfigurableComponent component,
final
             this.component = component;
             this.validationContextFactory = validationContextFactory;
             this.serviceProvider = serviceProvider;
    +        this.name = new AtomicReference<>(component.getClass().getSimpleName());
    --- End diff --
    
    My concern is it looks like quite a few things inherit from AbstractConfiguredComponent,
and now every one of them has changed, not just StandardProcessorNode


> StandardProcessorNode hides 'name' instance variable defined in AbstractConfiguredComponent
> -------------------------------------------------------------------------------------------
>
>                 Key: NIFI-1317
>                 URL: https://issues.apache.org/jira/browse/NIFI-1317
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>            Priority: Minor
>             Fix For: 0.5.0
>
>
> The final instance of a component contains two instance variables called _name_ with
different values



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message