Return-Path: 
 <commits-return-15773-apmail-nifi-commits-archive=nifi.apache.org@nifi.apache.org>
X-Original-To: apmail-nifi-commits-archive@minotaur.apache.org
Delivered-To: apmail-nifi-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 356A618A95
	for <apmail-nifi-commits-archive@minotaur.apache.org>;
 Sun, 15 Nov 2015 15:48:11 +0000 (UTC)
Received: (qmail 22191 invoked by uid 500); 15 Nov 2015 15:48:11 -0000
Delivered-To: apmail-nifi-commits-archive@nifi.apache.org
Received: (qmail 22156 invoked by uid 500); 15 Nov 2015 15:48:11 -0000
Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@nifi.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@nifi.apache.org>
List-Post: <mailto:commits@nifi.apache.org>
List-Id: <commits.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list commits@nifi.apache.org
Received: (qmail 22136 invoked by uid 99); 15 Nov 2015 15:48:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Nov 2015 15:48:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id F38AA2C0450
	for <commits@nifi.apache.org>; Sun, 15 Nov 2015 15:48:10 +0000 (UTC)
Date: Sun, 15 Nov 2015 15:48:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.12842354.1435853737000.74944.1447602490939@Atlassian.JIRA>
In-Reply-To: <JIRA.12842354.1435853737000@Atlassian.JIRA>
References: <JIRA.12842354.1435853737000@Atlassian.JIRA>
 <JIRA.12842354.1435853737533@arcas>
Subject: [jira] [Commented] (NIFI-748) If unable to find a specific
 Provenance event, should not fail entire search
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/NIFI-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005946#comment-15005946 ] 

ASF GitHub Bot commented on NIFI-748:
-------------------------------------

Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/123#discussion_r44873192
  
    --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java ---
    @@ -47,9 +46,6 @@
     public class DocsReader {
         private final Logger logger = LoggerFactory.getLogger(DocsReader.class);
     
    -    public DocsReader(final List<File> storageDirectories) {
    -    }
    -
    --- End diff --
    
    100% agree. Other projects use annotations to warn folks of risk when using public methods that aren't extension points (e.g. @PublicForTests or @Experimental), but I'd settle for a comment.
    



> If unable to find a specific Provenance event, should not fail entire search
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-748
>                 URL: https://issues.apache.org/jira/browse/NIFI-748
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Oleg Zhurakousky
>             Fix For: 0.4.0
>
>
> We have a case where running with the prov being written to a disk that can be ejected. Disk was accidentally ejected while running. Provenance Event appears to have been indexed but event is not in the repo.
> Specifically, we are reaching Line 104 of DocsReader:
> {code}
> throw new IOException("Failed to find Provenance Event " + d);
> {code}
> As a result, searching for a specific Component ID is returning an error, so we can't search on that Component ID at all (unless we shrink the time range to a time when that didn't occur).
> We should generate a warning, and notify the user that X number of events could not be found and show what we can, rather than erroring out entirely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)