nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-985) Custom log prefix for LogAttribute processor
Date Wed, 23 Sep 2015 21:16:05 GMT

    [ https://issues.apache.org/jira/browse/NIFI-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905273#comment-14905273
] 

ASF GitHub Bot commented on NIFI-985:
-------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/90#discussion_r40258768
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/LogAttribute.java
---
    @@ -123,12 +133,26 @@ protected void init(final ProcessorInitializationContext context)
{
         protected String processFlowFile(final ProcessorLog logger, final DebugLevels logLevel,
final FlowFile flowFile, final ProcessSession session, final ProcessContext context) {
             final Set<String> attributeKeys = getAttributesToLog(flowFile.getAttributes().keySet(),
context);
             final ProcessorLog LOG = getLogger();
    +        final String dashedLine;
    +
    +        String logPrefix = context.getProperty(LOG_PREFIX).evaluateAttributeExpressions().getValue();
    --- End diff --
    
    My apologies, I led you slightly astray in method mentioned before.  The evaluateAttributeExpressions
seems like it would benefit from making use of the current flowfile,  #evaluateAttributeExpressions(FlowFile
flowfile).  Otherwise, everything looks great.  If you would like me to make this change on
merge, let me know.  Otherwise, that would be the last adjustment needed to call this complete.


> Custom log prefix for LogAttribute processor
> --------------------------------------------
>
>                 Key: NIFI-985
>                 URL: https://issues.apache.org/jira/browse/NIFI-985
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Joe Mészáros
>            Priority: Minor
>              Labels: improvement, log
>         Attachments: nifi_log_prefix_updated.png
>
>
> When you have a data flow with a bunch of LogAttribute processors it is really hard to
identify the right LogAttribute processor in the log file and distinguish the output of different
LogAttribute processors.
> There is a new property, called log prefix, which helps the user to set a custom log
prefix for each Log Attribute processor, which will appear in the log output of the processor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message