nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Witt (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (NIFI-790) Create reporting task to deliver metrics to Apache Ambari
Date Mon, 17 Aug 2015 16:53:46 GMT

    [ https://issues.apache.org/jira/browse/NIFI-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699809#comment-14699809
] 

Joseph Witt edited comment on NIFI-790 at 8/17/15 4:53 PM:
-----------------------------------------------------------

Contrib-check is solid.

In nifi-amabari-reporting-task/pom.xml there are some extraneous tabs.  Might want to double
check.  Not a big deal obviously but a nice to do.

Can kill the reference to "<version>1.10.19</version>" as it is inherited.

Great job! on the NOTICE file in the nar.  But, you do need to also update the nifi-assembly/NOTICE
as well.  Anything in the child elements needs to be rolled up into the higher level.  Since
these are only binary deps they only need to be in the nars and the assembly.

MetricsBuilder.java:39 consider adding 'final'.

This thing works great by the way.  Please consider adding an 'additional documentation' page
for this to explain what someone would need to do for configuring ambari.  

Nice!

Once these issues and the unit test issue is sorted I'm a +1.

Thanks
Joe




was (Author: joewitt):
Contrib-check is solid.

In nifi-amabari-reporting-task/pom.xml there are some extraneous tabs.  Might want to double
check.  Not a big deal obviously but a nice to do.

Can kill the reference to "<version>1.10.19</version>" as it is inherited.

Great job! on the NOTICE file in the nar.

MetricsBuilder.java:39 consider adding 'final'.

This thing works great by the way.  Please consider adding an 'additional documentation' page
for this to explain what someone would need to do for configuring ambari.  

Nice!

Once the unit test issue is sorted I'm a +1 on the rest.

Thanks
Joe



> Create reporting task to deliver metrics to Apache Ambari
> ---------------------------------------------------------
>
>                 Key: NIFI-790
>                 URL: https://issues.apache.org/jira/browse/NIFI-790
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Bryan Bende
>             Fix For: 0.3.0
>
>         Attachments: NIFI-790.patch
>
>
> Apache Ambari seems to be a good place to aggregate metrics and we're hearing from folks
that want to use it.
> We should provide a reporting task that makes it extremely simple to send to Apache Ambari.
> Probably best to do a simple first pass of basic metrics off high-level flow summary
stuff.  So we can use that to get more detailed feedback on where to go with it next.  Ambari
seems to have a REST API to deliver to.
> https://ambari.apache.org/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message