nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Gilman (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (NIFI-482) users are currently able to evaluate a function against the result of an aggregrate function
Date Sat, 20 Jun 2015 02:50:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594303#comment-14594303
] 

Matt Gilman edited comment on NIFI-482 at 6/20/15 2:49 AM:
-----------------------------------------------------------

[~markap14] Verified build. Reviewed code changes. When executing the supplied sample, the
first expression is invalid as expected. However the validation error looked a little suspect
[1]. I'm not sure if this was intended or if it was something that was overlooked.

+1 for the expression language changes. If you want to revisit the validation error if it's
not what you were expecting to see, that's cool too :)

[1] 'attribute.1' validated against '${allMatchingAttributes('a.*'):contains('2'):count():gt(2)}'
is invalid because Expression attempts to call function 'null' on the result of 'null'. This
is not allowed. Instead, use "${literal( ${<embedded expression>} ):null(...)"


was (Author: mcgilman):
[~markap14] Verified build. Review code changes. When executing the supplied sample, the first
expression is invalid as expected. However the validation error looked a little suspect [1].
I'm not sure if this was intended or if it was something that was overlooked.

+1 for the expression language changes. If you want to revisit the validation error if it's
not what you were expecting to see, that's cool too :)

[1] 'attribute.1' validated against '${allMatchingAttributes('a.*'):contains('2'):count():gt(2)}'
is invalid because Expression attempts to call function 'null' on the result of 'null'. This
is not allowed. Instead, use "${literal( ${<embedded expression>} ):null(...)"

> users are currently able to evaluate a function against the result of an aggregrate function
> --------------------------------------------------------------------------------------------
>
>                 Key: NIFI-482
>                 URL: https://issues.apache.org/jira/browse/NIFI-482
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 0.0.2
>            Reporter: Ben Icore
>            Assignee: Mark Payne
>             Fix For: 0.2.0
>
>         Attachments: 0001-NIFI-482-Allowed-for-new-literal-function.-Make-expr.patch
>
>
> users should not be able to evaluate a function against the result of an aggregrate function
as it will often yield indeterminate results.
>  
> expression should be invalid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message