nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (NIFI-561) FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test files.
Date Thu, 30 Apr 2015 03:46:05 GMT

     [ https://issues.apache.org/jira/browse/NIFI-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Busbey updated NIFI-561:
-----------------------------
    Attachment: NIFI-561.1.patch.txt

patch that changes to JUnit / Maven way of handling test files and temp folders.

tested by running {{mvn -Dtest=FileBasedClusterNodeFirewallTest -DfailIfNoTests=false package}}
and examining test log output.

> FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test files.
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-561
>                 URL: https://issues.apache.org/jira/browse/NIFI-561
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Core Framework
>    Affects Versions: 0.0.1
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: NIFI-561.1.patch.txt
>
>
> Right now FileBasedClusterNodeFirewallTest sets up its own test directory and reads test
files directly out of hte source tree.
> These are both undesirable
> * setting up a temp directory in java.io.tmp manually makes more work when we could use
a junit tempdirectory (it also makes it more likely that we'll mess up parallel builds)
> * reading out of the source tree prevents adding in maven rules that process the test
resources before the test (as opposed to reading them out of target/classes, where teh test
resource handler will put the finished products).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message