[ https://issues.apache.org/jira/browse/NIFI-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481158#comment-14481158
]
Matt Gilman commented on NIFI-433:
----------------------------------
A couple comments...
- Directory listings can return null. This can happen if the file is not a directory or if
an IOException occurs. We need to protect against that in NarUnpacker. Will lead to a NPE
otherwise.
- In properties file for the unit tests I would make all paths point somewhere under target.
While I understand the application is not starting during the unit test and some of those
paths aren't used I would still update them for consistency and protect against future changes.
- Maybe add some protection when an alternate location is specified in the properties file
but the value is blank. I believe this would default to the current working directory which
is probably not what the user is expecting.
> allow for mulitple/custom lib directories
> -----------------------------------------
>
> Key: NIFI-433
> URL: https://issues.apache.org/jira/browse/NIFI-433
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 0.0.2
> Reporter: Ben Icore
> Assignee: Brandon DeVries
> Priority: Minor
> Attachments: 0001-NIFI-433.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
|