Return-Path: X-Original-To: apmail-nifi-commits-archive@minotaur.apache.org Delivered-To: apmail-nifi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06DC917F92 for ; Mon, 23 Mar 2015 19:20:15 +0000 (UTC) Received: (qmail 5848 invoked by uid 500); 23 Mar 2015 19:20:15 -0000 Delivered-To: apmail-nifi-commits-archive@nifi.apache.org Received: (qmail 5808 invoked by uid 500); 23 Mar 2015 19:20:14 -0000 Mailing-List: contact commits-help@nifi.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.incubator.apache.org Delivered-To: mailing list commits@nifi.incubator.apache.org Received: (qmail 5799 invoked by uid 99); 23 Mar 2015 19:20:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2015 19:20:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 23 Mar 2015 19:20:13 +0000 Received: (qmail 4671 invoked by uid 99); 23 Mar 2015 19:19:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2015 19:19:53 +0000 Date: Mon, 23 Mar 2015 19:19:53 +0000 (UTC) From: "Mark Payne (JIRA)" To: commits@nifi.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (NIFI-450) FileSystemRepository's subtasks should catch Throwable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/NIFI-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-450: ---------------------------- Attachment: 0001-NIFI-450-Catch-Throwable-from-all-implementations-of.patch > FileSystemRepository's subtasks should catch Throwable > ------------------------------------------------------ > > Key: NIFI-450 > URL: https://issues.apache.org/jira/browse/NIFI-450 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Reporter: Mark Payne > Fix For: 0.1.0 > > Attachments: 0001-NIFI-450-Catch-Throwable-from-all-implementations-of.patch > > > The DestroyExpiredArchiveClaims and BinDestructableClaims classes should wrap their implementations of the run() method with a try {...} catch (Throwable t) {...} > If any Throwable escapes right now, it causes some pretty bad results, so we shouldn't let this happen. As a result, it could leave behind some files in the repo that won't be cleaned up until restart if a Throwable is thrown, but that's better than letting the thread die. -- This message was sent by Atlassian JIRA (v6.3.4#6332)