nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-450) FileSystemRepository's subtasks should catch Throwable
Date Mon, 23 Mar 2015 19:58:54 GMT

    [ https://issues.apache.org/jira/browse/NIFI-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376512#comment-14376512
] 

ASF subversion and git services commented on NIFI-450:
------------------------------------------------------

Commit 54f3476a4cc975f52d543a53f1f9aec97ba3b858 in incubator-nifi's branch refs/heads/develop
from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=54f3476 ]

NIFI-450: Catch Throwable from all implementations of Runnable in the FileSystemRepository;
these are expected to always be running, so if anything odd like an OutOfMemoryError occurs,
this needs to be caught rather than allowing the thread to die


> FileSystemRepository's subtasks should catch Throwable
> ------------------------------------------------------
>
>                 Key: NIFI-450
>                 URL: https://issues.apache.org/jira/browse/NIFI-450
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>             Fix For: 0.1.0
>
>         Attachments: 0001-NIFI-450-Catch-Throwable-from-all-implementations-of.patch
>
>
> The DestroyExpiredArchiveClaims and BinDestructableClaims classes should wrap their implementations
of the run() method with a try {...} catch (Throwable t) {...}
> If any Throwable escapes right now, it causes some pretty bad results, so we shouldn't
let this happen. As a result, it could leave behind some files in the repo that won't be cleaned
up until restart if a Throwable is thrown, but that's better than letting the thread die.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message