nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Witt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-221) Build Processors that allow for receiving and responding to arbitrary HTTP requests
Date Sun, 01 Mar 2015 14:58:04 GMT

    [ https://issues.apache.org/jira/browse/NIFI-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342267#comment-14342267
] 

Joseph Witt commented on NIFI-221:
----------------------------------

mark

i reviewed the code/docs, did a full clean build, ran the app.  All looks good.  Also big
thanks to adam taft for his ideas/input here.

Comments:
- I think the practice of equality checks on incompatible types is a bit funky.  That is not
unique to this processor set but is a general thing I've noticed.  I am personally not a fan
of this fwiw.  When we do this we're not checking 'equality' in a Java sense.  It's more like
checking the string form of an enum.

- The depth of outstanding requests on any http context appears to be 50.  Perhaps this should
be configurable and 50 could be a default.  This feels pretty arbitrary.  Do you know what
someone like Jetty does here?

- These processors depend on the controller service and I understand why that was the more
powerful route.  To Adam's point though I do think that will limit their utility at least
for a while.  These as they are definitely are power-user capabilities.  I think once the
controller services are modifiable at runtime then this becomes more approachable.  I also
think that having a stock content viewer will help tremendously.  A user then can visually
create web services and do so in a step by step iterative feedback cycle - Pretty awesome.

- Tests?  I am not seeing any.  This is the only thing holding me back from a +1.  This stuff
definitely needs unit tests.

> Build Processors that allow for receiving and responding to arbitrary HTTP requests
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-221
>                 URL: https://issues.apache.org/jira/browse/NIFI-221
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>
> The idea here is that we can receipt an HTTP request and use NiFi, in essence to build
a web server graphically. This opens up a wide range of possibilities, by allowing a DFM to
easily add a web front-end to any service that NiFi can interact with or to perform any sort
of action that NiFi has the ability to perform, such as data format conversion, etc.
> For example, if you want to provide a web-based front-end to an SFTP Server, you could
do so by creating a flow like:
> ReceiveHTTPRequest -> PutSFTP -> RespondHTTPRequest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message