nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Payne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-84) GetJMS* should create FlowFile attributes for all key/value pairs in a MapMessage
Date Wed, 04 Feb 2015 13:47:35 GMT

    [ https://issues.apache.org/jira/browse/NIFI-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305079#comment-14305079
] 

Mark Payne commented on NIFI-84:
--------------------------------

Toivo,

I was able to look over the test file and the JmsProcessingSummary class. I noticed that you
are using the @author tags within those. I don't know that ASF forbids them, but it's something
that we've avoided on this project. There's a good explanation of why many discourage this
practice at http://opensource.com/law/14/2/copyright-statements-source-files. Rather, we allow
Git to provide provenance of what has been provided by whom. Would you be okay removing the
@author tags?

Thanks
-Mark

> GetJMS* should create FlowFile attributes for all key/value pairs in a MapMessage
> ---------------------------------------------------------------------------------
>
>                 Key: NIFI-84
>                 URL: https://issues.apache.org/jira/browse/NIFI-84
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Gilman
>            Priority: Minor
>         Attachments: JmsConsumer2.java, JmsConsumer2.java, JmsProcessingSummary.java,
TestJmsConsumer.java
>
>
> Attributes added should be "jms.mapmessage." + JMS message key, with the given value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message