Return-Path: X-Original-To: apmail-nifi-commits-archive@minotaur.apache.org Delivered-To: apmail-nifi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72B10173D6 for ; Thu, 29 Jan 2015 15:47:58 +0000 (UTC) Received: (qmail 79038 invoked by uid 500); 29 Jan 2015 15:47:58 -0000 Delivered-To: apmail-nifi-commits-archive@nifi.apache.org Received: (qmail 78996 invoked by uid 500); 29 Jan 2015 15:47:58 -0000 Mailing-List: contact commits-help@nifi.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.incubator.apache.org Delivered-To: mailing list commits@nifi.incubator.apache.org Received: (qmail 78987 invoked by uid 99); 29 Jan 2015 15:47:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 15:47:58 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 29 Jan 2015 15:47:56 +0000 Received: (qmail 77674 invoked by uid 99); 29 Jan 2015 15:47:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 15:47:36 +0000 Date: Thu, 29 Jan 2015 15:47:36 +0000 (UTC) From: "Joseph Witt (JIRA)" To: commits@nifi.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NIFI-291) Address findings from 0.0.1 release process MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/NIFI-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297034#comment-14297034 ] Joseph Witt commented on NIFI-291: ---------------------------------- -rw-rw-r--. 1 joe joe 6418368 Jan 23 09:27 scala-library-2.8.2.jar -rw-rw-r--. 1 joe joe 521157 Jan 23 09:27 mail-1.4.7.jar -rw-rw-r--. 1 joe joe 391834 Jan 23 09:27 log4j-1.2.15.jar -rw-rw-r--. 1 joe joe 106813 Jan 23 09:27 nifi-utils-0.0.1-incubating.jar -rw-rw-r--. 1 joe joe 604182 Jan 23 09:27 zookeeper-3.3.4.jar -rw-rw-r--. 1 joe joe 4229 Jan 23 09:27 metrics-annotation-2.2.0.jar -rw-rw-r--. 1 joe joe 62983 Jan 23 09:27 activation-1.1.jar -rw-rw-r--. 1 joe joe 17148 Jan 23 09:27 nifi-security-utils-0.0.1-incubating.jar -rw-rw-r--. 1 joe joe 53244 Jan 23 09:27 jopt-simple-3.2.jar -rw-rw-r--. 1 joe joe 1251514 Jan 23 09:27 snappy-java-1.0.5.jar -rw-rw-r--. 1 joe joe 412739 Jan 23 09:27 commons-lang3-3.3.2.jar -rw-rw-r--. 1 joe joe 3223773 Jan 23 09:27 kafka_2.8.2-0.8.1.jar -rw-rw-r--. 1 joe joe 32753 Jan 23 09:27 nifi-kafka-processors-0.0.1-incubating.jar -rw-rw-r--. 1 joe joe 82123 Jan 23 09:27 metrics-core-2.2.0.jar -rw-rw-r--. 1 joe joe 64009 Jan 23 09:27 zkclient-0.3.jar -rw-rw-r--. 1 joe joe 42716 Jan 23 09:27 nifi-processor-utils-0.0.1-incubating.jar -rw-rw-r--. 1 joe joe 87325 Jan 23 09:27 jline-0.9.94.jar Kafka's very own LICENSE: https://github.com/apache/kafka/blob/0.8.1/LICENSE Kafka's very own NOTICe: https://github.com/apache/kafka/blob/0.8.1/NOTICE Should it not have to indicate the bsd style 3 clause: http://www.scala-lang.org/license.html? >From the dependecies file in the bundle: From: 'an unknown organization' - ZkClient (https://github.com/sgroschupf/zkclient) com.101tec:zkclient:jar:0.3 License: The Apache Software License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - Metrics Annotations (http://metrics.codahale.com/metrics-annotation/) com.yammer.metrics:metrics-annotation:jar:2.2.0 License: Apache License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.html) - Metrics Core Library (http://metrics.codahale.com/metrics-core/) com.yammer.metrics:metrics-core:jar:2.2.0 License: Apache License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.html) - JavaBeans Activation Framework (JAF) (http://java.sun.com/products/javabeans/jaf/index.jsp) javax.activation:activation:jar:1.1 License: Common Development and Distribution License (CDDL) v1.0 (https://glassfish.dev.java.net/public/CDDLv1.0.html) - JLine (http://jline.sourceforge.net) jline:jline:jar:0.9.94 License: BSD (LICENSE.txt) - JOpt Simple (http://jopt-simple.sourceforge.net) net.sf.jopt-simple:jopt-simple:jar:3.2 License: The MIT License (http://www.opensource.org/licenses/mit-license.php) - Apache Kafka (http://kafka.apache.org) org.apache.kafka:kafka_2.8.2:jar:0.8.1 License: The Apache Software License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - zookeeper org.apache.zookeeper:zookeeper:jar:3.3.4 ... From: 'LAMP/EPFL' (http://lamp.epfl.ch/) - scala-library (http://www.scala-lang.org/) org.scala-lang:scala-library:jar:2.8.2 License: BSD-like (http://www.scala-lang.org/downloads/license.html) From: 'Oracle' (http://www.oracle.com) - JavaMail API (compat) (http://kenai.com/projects/javamail/mail) javax.mail:mail:jar:1.4.7 License: CDDL (http://www.sun.com/cddl) License: GPLv2+CE (https://glassfish.java.net/public/CDDL+GPL_1_1.html) So at lease each of these non Apache items needs to be verified to be in LICENSE/NOTICE as appropriate or added. > Address findings from 0.0.1 release process > ------------------------------------------- > > Key: NIFI-291 > URL: https://issues.apache.org/jira/browse/NIFI-291 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build > Reporter: Joseph Witt > Assignee: Joseph Witt > Priority: Minor > > Josh Elser: > - Readme.txt should have License Header > - nbactions.xml is odd in rat exclusions: perhaps we can comment why it is there (for netbeans users) > Andrew Purtell: > - Organizations is wrong in pom. It says > http://nifi.incubating.apache.org/ > but should be: > http://nifi.incubator.apache.org/ > Billie Rinaldi: > The nar and war files deployed in the > orgapachenifi-1022 repository seem to have default LICENSE files that don't > have license info for their bundled dependencies, but they do all have > DEPENDENCIES files listing this information. I haven't worked with these > dependencies files before. Are they sufficient for communicating license > information? > Justin Mclean: > Some suggestions: > - Consider having separate licence and notice file for the binary release > - The NOTICE file is a little odd in that while it mentions what licenses effect notice it > doesn't list the software, but they are listed in the license file. Perhaps take a look at > what other projects have done. > As per [1] the source LICENSE should only mention what's bundled in the source bundle and > the binary LICENSE should only mention what's bundled in the binary release. > I think you have the content right (hence my +1) just that there's no need to mention the > binary parts in the source release LICENSE. Having extra content in license is not as bad > than having missing licences. > I'd suggest (and it's only a suggestion) having two files (eg LICENSE.src and LICENSE.bin) > in version control and put in right one into each bundle (and rename to LICENSE) as part of > your release process. There are other approaches ie construct each LICENSE file from parts, > but this seems the simplest way to me. > Thanks, > Justin > 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > For additional commands, e-mail: general-help@incubator.apache.org > Jan I: > I am a bit confused about the mangling of license/notice files in respect > of the source/binary releases. > Can I please ask you to make a clear distinction between source and binary > (which is not official ASF release) in the next release. > Billie R: > Beware that the license does not currently cover all of the dependencies > bundled in the nars/wars. (As the license for the source package, it > doesn't have to.) The one I noticed was nifi-kafka-nar, but there could be > others. > -- Items found in the bundled dependencies of the kafka Nar > -rw-rw-r--. 1 joe joe 6418368 Jan 23 09:27 scala-library-2.8.2.jar > -rw-rw-r--. 1 joe joe 521157 Jan 23 09:27 mail-1.4.7.jar > -rw-rw-r--. 1 joe joe 391834 Jan 23 09:27 log4j-1.2.15.jar > -rw-rw-r--. 1 joe joe 106813 Jan 23 09:27 nifi-utils-0.0.1-incubating.jar > -rw-rw-r--. 1 joe joe 604182 Jan 23 09:27 zookeeper-3.3.4.jar > -rw-rw-r--. 1 joe joe 4229 Jan 23 09:27 metrics-annotation-2.2.0.jar > -rw-rw-r--. 1 joe joe 62983 Jan 23 09:27 activation-1.1.jar > -rw-rw-r--. 1 joe joe 17148 Jan 23 09:27 nifi-security-utils-0.0.1-incubating.jar > -rw-rw-r--. 1 joe joe 53244 Jan 23 09:27 jopt-simple-3.2.jar > -rw-rw-r--. 1 joe joe 1251514 Jan 23 09:27 snappy-java-1.0.5.jar > -rw-rw-r--. 1 joe joe 412739 Jan 23 09:27 commons-lang3-3.3.2.jar > -rw-rw-r--. 1 joe joe 3223773 Jan 23 09:27 kafka_2.8.2-0.8.1.jar > -rw-rw-r--. 1 joe joe 32753 Jan 23 09:27 nifi-kafka-processors-0.0.1-incubating.jar > -rw-rw-r--. 1 joe joe 82123 Jan 23 09:27 metrics-core-2.2.0.jar > -rw-rw-r--. 1 joe joe 64009 Jan 23 09:27 zkclient-0.3.jar > -rw-rw-r--. 1 joe joe 42716 Jan 23 09:27 nifi-processor-utils-0.0.1-incubating.jar > -rw-rw-r--. 1 joe joe 87325 Jan 23 09:27 jline-0.9.94.jar -- This message was sent by Atlassian JIRA (v6.3.4#6332)