netbeans-netcat mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiří Kovalský <jiri.koval...@oracle.com>
Subject Re: Java Editor Tribe Codefolding review
Date Sat, 10 Mar 2018 12:42:39 GMT
Great job José. Did you modify the test specification accordingly?

Thanks a lot,
-Jirka

Dne 9.3.2018 v 21:34 José J. Rodriguez napsal(a):

> I'm not getting this back from the list since I sent it over 3 hours 
> ago, so here it goes again, just in case. Sorry if it's turns out 
> duplicate...
> 
> -----------------------------------
> 
> Here's my complete review (search for the word FAIL for quick access, 
> there are 2 cases...):
> 
> 
> netbeans netcat Editor - Codefolding review:
> 
> 1. Basic Code Folding...
> 
> 1.1. Code folding after opening a file:
>      - OK. (Test Suite Note: there are initially no javadoc comments in 
> MyClass.java)
> 
> 1.2. Add javadoc code:
>      - OK.
> 
> 1.3. Add/Remove code (1):
>      - OK
> 
> 1.4. Add/Remove code (2):
>      - OK
> 
> 1.5. Collapse cases:
>      - OK.
> 
> 1.6. Options - Disable/Enable CF:
>      - OK.
> 
> 1.7. Display Options:
>      - OK. (Test Suite Note: order of Results is different to order of 
> Steps, this is confusing)
> 
> 1.8. Options - Typing in editor:
>      - OK.
> 
> 1.9. Options - Scrolling:
>      - FAIL: method A.a() is collapsed less than half the attempts. No 
> pattern easily discernible.
> 
> 1.10. Java Settings:
>      - OK.
> 
> 
> 
> 2. Code Folding Actions...
> 
> 2.1. CF Mouse Actions:
>      - OK.
> 
> 2.2. Code Folding main menu:
>      - OK.
> 
> 2.3. Collapse and expand single code fold:
>      - OK.
> 
> 2.4. Collapse and expand all code folds :
>      - OK.
> 
> 2.5. CF Shortcut Actions:
>      - OK.
> 
> 2.6. Show Collapsed Code in Tooltip:
>      - OK.
> 
> 2.7. Open No Parsable File :
>      - OK.
> 
> 2.8. Empty File:
>      - OK.
> 
> 
> 
> 3. Defining Custom Code Folding ...
> 
> 3.1. Add custom code fold:
>      - OK.
> 
> 3.2. Add custom code fold with description:
>      - OK.
> 
> 3.3. Add custom code fold (collapse by default):
>      - OK.
> 
> 3.4. Change custom code fold:
>      - OK.
> 
> 3.5. Remove custom code fold:
>      - OK.
> 
> 
> 
> 4. Overlapped or corrupted folds, edge cases:
> 
> 4.1. Overlapped folds:
>      - OK.
> 
> 4.2. Corrupt Custom Folds 1:
>      - OK.
> 
> 4.3. Corrupt Custom Folds 2:
>      - OK. (Test Suite Note: the example does not show the letter "a" at 
> all)
> 
> 4.4. Corrupt Custom Folds 3:
>      - OK.
> 
> 4.5. Comments after block:
>      - OK.
> 
> 4.6. Two methods on the same line:
>      - OK.
>      - There is one issue I found while testing this out, if first 
> method takes several lines and you click the collapse mark, it will 
> collapse and the minus sign will remain. Clicking it again will collapse 
> the second method. From then on, you can only expand and collapse the 
> second method with the ± sign.
> 
> 4.7. JavaDoc / Normal comment:
>      - OK.
> 
> 
> 
> 5. Miscellaneous...
> 
> 5.1. Deleting when CF is collapsed:
>      - OK.
> 
> 5.2. Interaction with Surrounding Features 1 - Basic:
>      - OK.
> 
> 5.3. Interactions with Surrounding Features 2 - Bookmarks
>      - OK.
> 
> 5.4. Interactions with Surrounding Features 3 - Breakpoints:
>      - OK.
> 
> 5.5. Interactions with Surrounding Features 4 - Find & Replace:
>      - FAIL, each search/next/F3 action seems to expand only 1 fold, if 
> string is nested deeper, you need to keep searching (actually, it has 
> been this way in 8.2 and probably earlier versions, always hated it).
> 
> 5.6. Background/Foreground color:
>      - OK.
> 
> 
> 
> Regards,
> Joe1962
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: netcat-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: netcat-help@netbeans.apache.org
> 
> For further information about the NetBeans mailing lists, visit:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki.apache.org_confluence_display_NETBEANS_Mailing-2Blists&d=DwIDaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=Ya27mQph-7RCx7oA42Arct7gnBPJpgy7aFTy3k7zNI8&s=dCtq-8VlbmnxJ2EYwbxiznUvVd9oipcLZS2LRLgjv20&e=

> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: netcat-unsubscribe@netbeans.apache.org
For additional commands, e-mail: netcat-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Mime
View raw message