Mailing-List: contact dev-help@netbeans.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@netbeans.incubator.apache.org
From: matthiasblaesing <git@git.apache.org>
To: dev@netbeans.incubator.apache.org
Reply-To: dev@netbeans.incubator.apache.org
Message-ID: <git-pr-52-incubator-netbeans@git.apache.org>
Subject: [GitHub] incubator-netbeans pull request #52: First batch of xml modules for review
Content-Type: text/plain
Date: Tue,  3 Oct 2017 19:23:13 +0000 (UTC)
archived-at: Tue, 03 Oct 2017 19:23:18 -0000

GitHub user matthiasblaesing opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/52

    First batch of xml modules for review

    Please see the individual commits for the details.
    
    The biggest changeset comes from xml.text, as there many unittest files 
    were adjusted to contain a header and in turn the unittests were modified
    accordingly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matthiasblaesing/incubator-netbeans xml1-review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----
commit fc3b05a7427294c4ee165d5463e583f04057b9ee
Author: Matthias Bläsing <mblaesing@doppel-helix.eu>
Date:   2017-10-03T16:18:44Z

    [NETBEANS-54] Module review xml.text.obsolete90
    
    - no external library
    - checked Rat report; added license header to testfiles and ensured 
      tests still run cleanly, removed unused file, that only differs from
      neighbouring file by license
    - skimmed through the module, did not notice additional problems

commit 6e2e69edb6b6d0543938d99c00f62ccbe3948434
Author: Matthias Bläsing <mblaesing@doppel-helix.eu>
Date:   2017-10-03T16:41:58Z

    [NETBEANS-54] Module review xml.core
    
    - no external library
    - checked Rat report; added license header to testfiles
    - skimmed through the module, did not notice additional problems

commit 74d7170729987212710f0572abe4372decfa0db9
Author: Matthias Bläsing <mblaesing@doppel-helix.eu>
Date:   2017-10-03T17:07:59Z

    [NETBEANS-54] Module review xml.retriever
    
    - no external library
    - checked Rat report; added license header to testfiles
    - skimmed through the module, did not notice additional problems

commit 2eb40408a380977d58650fdd2bf70e0170a7e1ca
Author: Matthias Bläsing <mblaesing@doppel-helix.eu>
Date:   2017-10-03T17:17:53Z

    [NETBEANS-54] Module review xml.multiview
    
    - no external library
    - checked Rat report; added license header to testfiles, manually 
      updated unconverted license headers
    - skimmed through the module, did not notice additional problems

commit d320afd4cc151f250b6b424476832dfa9d06ddd7
Author: Matthias Bläsing <mblaesing@doppel-helix.eu>
Date:   2017-10-03T17:57:06Z

    [NETBEANS-54] Module review xsl
    
    - no external library
    - checked Rat report; added testfiles to exclude list for rat
    - skimmed through the module, did not notice additional problems

commit 2fe14876dca137fc2653d2eeacbd78895288fb2e
Author: Matthias Bläsing <mblaesing@doppel-helix.eu>
Date:   2017-10-03T19:17:52Z

    [NETBEANS-54] Module review xml.text
    
    - no external library
    - checked Rat report; added license to many test files and adjusted
      tests to match these; exclude GUI visible sample data and sepcial
      test data
    - skimmed through the module, did not notice additional problems

----


---