Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 25948200D16 for ; Tue, 10 Oct 2017 21:20:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 24336160BE0; Tue, 10 Oct 2017 19:20:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6DC501609CB for ; Tue, 10 Oct 2017 21:20:49 +0200 (CEST) Received: (qmail 21724 invoked by uid 500); 10 Oct 2017 19:20:48 -0000 Mailing-List: contact dev-help@netbeans.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@netbeans.incubator.apache.org Delivered-To: mailing list dev@netbeans.incubator.apache.org Received: (qmail 21713 invoked by uid 99); 10 Oct 2017 19:20:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 19:20:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 90CEC180E78 for ; Tue, 10 Oct 2017 19:20:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Am2qET_x8bDl for ; Tue, 10 Oct 2017 19:20:45 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id C974B5FDDC for ; Tue, 10 Oct 2017 19:20:44 +0000 (UTC) Received: (qmail 21631 invoked by uid 99); 10 Oct 2017 19:20:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 19:20:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A5A46F574B; Tue, 10 Oct 2017 19:20:43 +0000 (UTC) From: matthiasblaesing To: dev@netbeans.incubator.apache.org Reply-To: dev@netbeans.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib Content-Type: text/plain Message-Id: <20171010192043.A5A46F574B@git1-us-west.apache.org> Date: Tue, 10 Oct 2017 19:20:43 +0000 (UTC) archived-at: Tue, 10 Oct 2017 19:20:50 -0000 Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/114 Sorry, but this breaks the unittests. In these the CSS structure is parsed and the result is compared with a reference file. I would do this: - revert the changes to the files under `css.lib/test/unit/data` - add an exclusion pattern to the rat report task in the `nbbuild/build.xml` with the pattern `css.lib/test/unit/data/**` with a comment, that these are testdata files It would be nice if you could have another look at this. ---