Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 994EB200D12 for ; Sat, 7 Oct 2017 18:08:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 97BA61609D3; Sat, 7 Oct 2017 16:08:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DCCB51609B8 for ; Sat, 7 Oct 2017 18:08:04 +0200 (CEST) Received: (qmail 46607 invoked by uid 500); 7 Oct 2017 16:08:04 -0000 Mailing-List: contact dev-help@netbeans.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@netbeans.incubator.apache.org Delivered-To: mailing list dev@netbeans.incubator.apache.org Received: (qmail 46595 invoked by uid 99); 7 Oct 2017 16:08:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Oct 2017 16:08:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ED2F2D31B1 for ; Sat, 7 Oct 2017 16:08:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.521 X-Spam-Level: X-Spam-Status: No, score=-3.521 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_LINKBAIT=0.5, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lQBtAbHoVCBm for ; Sat, 7 Oct 2017 16:08:01 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id DF5465F367 for ; Sat, 7 Oct 2017 16:08:00 +0000 (UTC) Received: (qmail 46576 invoked by uid 99); 7 Oct 2017 16:08:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Oct 2017 16:08:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 021F4E030B; Sat, 7 Oct 2017 16:07:59 +0000 (UTC) From: matthiasblaesing To: dev@netbeans.incubator.apache.org Reply-To: dev@netbeans.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-netbeans issue #62: [NETBEANS-54] Module Review hibernate Content-Type: text/plain Message-Id: <20171007160800.021F4E030B@git1-us-west.apache.org> Date: Sat, 7 Oct 2017 16:07:59 +0000 (UTC) archived-at: Sat, 07 Oct 2017 16:08:05 -0000 Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/62 Looks better, but you still introduce a change into HibernateRevengTemplate.xml. You add a XML prolog to the file, that was not there before. So could you please: - remove that also - rebase your changes onto master - squash your changes together into one changeset Thank you! ---