netbeans-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antonio <anto...@vieiro.net>
Subject Want a PR? (was Re: nbproject/*-impl.xml and genfiles.properties)
Date Tue, 03 Oct 2017 09:51:13 GMT
On 03/10/17 11:09, Jaroslav Tulach wrote:
> Hello Antonio,
> thanks for your help.

My pleasure.

>> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
>> nbproject/genfiles.properties.
>>
>> These are automatically generated in the IDE so,
>>
>> - Should I remove them from git?
> 
> No, add them to the rat tool exclude list.

Done.

I've added '**/nbproject/*-impl.xml' and 
'**/nbproject/genfiles.properties' to the rat exclusion list. (Note: 
**/nbproject/, so that affects qa-test projects as well, and not 
*/nbproject that only affects the module).

Shall I submit a pull request with these?

> 
>> Problems to be solved centrally
>>      build.xml, build-impl.xml, project.properties, genfiles.properties,
> 
> I would suggest to add licenses to build.xml and project.properties - e.g.
> those that aren't generated.

Of course.

Mime
View raw message