netbeans-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matthiasblaesing <...@git.apache.org>
Subject [GitHub] incubator-netbeans issue #130: Cache external binaries downloaded from maven...
Date Thu, 12 Oct 2017 19:37:18 GMT
Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/130
  
    Looks good. The cache is a good idea - having one cache keeps the code simple and does
not risk corrupting a maven repository, so I would agree with that.
    
    If you are interested, I fixed the unittests for the module (one was introduced when the
extended maven coordinate syntax was added and the others are artifacts from license header
changes and missing files):
    
    https://github.com/matthiasblaesing/incubator-netbeans/commits/unittests_nbbuild
    
    Feel free to pull the commits into this branch, else I'll rebase the changes and will
propose these in a separate PR.


---

Mime
View raw message