netbeans-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matthiasblaesing <...@git.apache.org>
Subject [GitHub] incubator-netbeans issue #114: [NETBEANS-54] Module Review css.lib
Date Tue, 10 Oct 2017 19:20:43 GMT
Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/114
  
    Sorry, but this breaks the unittests. In these the CSS structure is parsed and the result
is compared with a reference file. I would do this:
    
    - revert the changes to the files under `css.lib/test/unit/data`
    - add an exclusion pattern to the rat report task in the `nbbuild/build.xml` with the
pattern `css.lib/test/unit/data/**` with a comment, that these are testdata files
    
    It would be nice if you could have another look at this.


---

Mime
View raw message