netbeans-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matthiasblaesing <...@git.apache.org>
Subject [GitHub] incubator-netbeans issue #96: Netbeans 54 review apisupport.refactoring
Date Sun, 08 Oct 2017 18:03:01 GMT
Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/96
  
    Yes I would revert the change to whereUsed.ref and instead add that file to the rat exclusion
list. There are other similiar cases already in the build.xml where modifying test-data causes
unittests to fail. There might be other files, that fall into the same category.
    
    If I modify unittest data I try to run the unittests and make sure modifying the data
does not cause test-failures. If they fail I try to base reasoning on good judgement :-)


---

Mime
View raw message