netbeans-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Friedländer (JIRA) <j...@apache.org>
Subject [jira] [Commented] (NETBEANS-168) Background scanning process needs a rethink
Date Fri, 18 Jan 2019 15:00:01 GMT

    [ https://issues.apache.org/jira/browse/NETBEANS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746376#comment-16746376
] 

Ivan Friedländer commented on NETBEANS-168:
-------------------------------------------

As I wrote the problems are two broken links and unix socket files.

The problem with symlinks is that the bad code is in multiple modules. And it's asynchronous,
so it's bad for debugging.


The author of these modules has forgotten that 
{code:java}
File.exists()
{code}
uses the FOLLOW_LINKS option. The masterfs linux module takes the status of files native
from linux. 

And on multiple places the file is checked with File.exist() and that generates the file created/deleted
loop.


With unix socket files is the is a similar problem from masterfs linux returns that file exist
and File.exist()  returns false..

The simplest fix is here [https://github.com/NBANDROIDTEAM/org-netbeans-modules-masterfs-patches/commit/e485736a1e68f338288be27ced28c1b1506fad5d]


A more complex option is to replace File.exist() to Files.exists(path, LinkOption.NOFOLLOW_LINKS) 
in all NB source codes.


And exclude "other files" from NB filesystem..


 

> Background scanning process needs a rethink
> -------------------------------------------
>
>                 Key: NETBEANS-168
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-168
>             Project: NetBeans
>          Issue Type: Bug
>          Components: ide - Performance, java - Platform, platform - Execution
>    Affects Versions: 8.2, 9.0, 10.0
>         Environment: NetBeans 8.2, Windows 10 x64
>            Reporter: Christian Lenz
>            Priority: Blocker
>              Labels: ca_survey, pull-request-available
>         Attachments: go-to-file.gif, messages - 10.0 vc3.log, messages 10.0 vc2.log,
messages.log, puls.7z, ui.log, uigestures 10.0 vc, wp-dms.7z
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Often, while cloning, switching branch, merging, opening etc. etc. NetBeans starts Background
scanning for changes, but it is not real background, because everything what you want to do
then, like changing the branch, commit, push, pull, open project, delete or whatever, is blocking
by this task and you can't cancel it, because it is essential.
> Either we need to rethink about this process like to make everything or most of the stuff
doing things in parallel or the task should really be cancelable. It is a pain in the ass
for big projects when they start to scan for changes. 
> It is a real world case because you acan see it when you work on NetBeans modules.
> Cheers
> Chris



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Mime
View raw message