netbeans-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NETBEANS-109) settings.xml factory generate mirror element instead of server
Date Tue, 31 Oct 2017 19:52:00 GMT

    [ https://issues.apache.org/jira/browse/NETBEANS-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227400#comment-16227400
] 

ASF GitHub Bot commented on NETBEANS-109:
-----------------------------------------

matthiasblaesing commented on issue #205: NETBEANS-109 fix server generation
URL: https://github.com/apache/incubator-netbeans/pull/205#issuecomment-340886742
 
 
   In general this looks good. My personal preference for the commit message is a short explanation/reasoning
for the change, that way a reader can deduce from the commit log why a change was introduced.
I suggest to adjust that.
   
   The test looks to be modeled following the existing tests and so the structure is generally
ok. A comment, that applies to the existing and new tests is, that relying on a specific formatting
is IMHO dangerous, using an XML parser and checking the DOM would give a more stable test
(this is just an observation and no request for a change). One thing, that should be removed
are the superfluous imports.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> settings.xml factory generate mirror element instead of server
> --------------------------------------------------------------
>
>                 Key: NETBEANS-109
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-109
>             Project: NetBeans
>          Issue Type: Bug
>          Components: projects - Maven
>    Affects Versions: 8.2
>         Environment: jdk 8 
>            Reporter: Eric Barboni
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 9.0
>
>
> module: maven.model
> Implementation of settings.xml factory contains an issue preventing to generate a well
formed xml file. Generating server is in fact generating mirror element in the servers sections.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message