netbeans-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NETBEANS-54) Clarify the status of donated files from
Date Mon, 30 Oct 2017 01:17:00 GMT


ASF GitHub Bot commented on NETBEANS-54:

junichi11 closed pull request #202: [NETBEANS-54] Module Review queries

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index c43c71b0f..fac230db7 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2044,6 +2044,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the
system in d
             <exclude name="projectuiapi/test/unit/src/org/netbeans/modules/project/uiapi/data/*.txt"
/> <!--test data-->
             <exclude name="properties/src/org/netbeans/modules/properties/"
/> <!-- template file -->
             <exclude name="properties.syntax/src/org/netbeans/modules/properties/syntax/PropertiesExample"
/> <!-- user visible example for properties language -->
+            <exclude name="queries/test/unit/src/org/netbeans/api/queries/data/*" />
<!--test data-->
             <exclude name=""
/> <!--template file-->
             <exclude name="spellchecker.dictionary_en/release/modules/dict/*.description"
/> <!--Description Files-->
             <exclude name="spi.navigator/test/unit/src/org/netbeans/modules/navigator/resources/lastsel/file.lastsel_mime1"
/> <!--empty file-->


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Clarify the status of donated files from
> --------------------------------------------------------------------
>                 Key: NETBEANS-54
>                 URL:
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: Bertrand Delacretaz
>              Labels: pull-request-available
>         Attachments:,,
> Reviewing the software grant [1] provided with the first NetBeans code donation, my understanding
is that not all files found in that zip are donated.
> The grant indicates that the contents of that file [2] ("Code File") are donated "excluding
any third-party and separately licensed material contained within the Code File". 
> I don't think we can consider that code ready to release as is, due to the uncertainty
that this creates w.r.t to which files are donated and which are not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and separately
licensed material". How such files are identified needs to be defined and documented, either
in scripts under version control or as a set of rules. The review process must be documented
and traceable, so that we can go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev list, referencing
this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF members have
> [2] under  - SHA256(
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a

This message was sent by Atlassian JIRA

View raw message