netbeans-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip
Date Sat, 30 Sep 2017 09:27:00 GMT

    [ https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187000#comment-16187000
] 

ASF GitHub Bot commented on NETBEANS-54:
----------------------------------------

Github user matthiasblaesing commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/23#discussion_r142002449
  
    --- Diff: db.sql.editor/test/unit/src/org/netbeans/modules/db/sql/editor/completion/SelectCompletionQueryTest.java
---
    @@ -125,11 +125,11 @@ public void runTest() throws Exception {
     
         public void testCompletion() throws Exception {
             StringBuilder sqlData = new StringBuilder();
    -        List<String> modelData = new ArrayList<String>();
    -        BufferedReader reader = new BufferedReader(new InputStreamReader(SelectCompletionQueryTest.class.getResource(getName()
+ ".test").openStream(), "utf-8"));
    -        try {
    +        List<String> modelData = new ArrayList<>();
    +        try (InputStream is = SelectCompletionQueryTest.class.getResourceAsStream(getName()
+ ".test");
    +                BufferedReader reader = new BufferedReader(new InputStreamReader(is,
"utf-8"))) {
                 boolean separatorRead = false;
    -            for (String line; (line = reader.readLine()) != null;) {
    +            for (String line = reader.readLine(); line != null; line = reader.readLine())
{
    --- End diff --
    
    I consider the previous one less readable. The previous version mixed initialization,
loop advance and checking and these parts are now separated into their corresponding sections.


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> --------------------------------------------------------------------
>
>                 Key: NETBEANS-54
>                 URL: https://issues.apache.org/jira/browse/NETBEANS-54
>             Project: NetBeans
>          Issue Type: Bug
>            Reporter: Bertrand Delacretaz
>         Attachments: categorized-1.zip, convert-headers-1.zip, JavaApplication9.java
>
>
> Reviewing the software grant [1] provided with the first NetBeans code donation, my understanding
is that not all files found in that zip are donated.
> The grant indicates that the contents of that file [2] ("Code File") are donated "excluding
any third-party and separately licensed material contained within the Code File". 
> I don't think we can consider that code ready to release as is, due to the uncertainty
that this creates w.r.t to which files are donated and which are not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and separately
licensed material". How such files are identified needs to be defined and documented, either
in scripts under version control or as a set of rules. The review process must be documented
and traceable, so that we can go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev list, referencing
this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF members have
access
> [2] under http://bits.netbeans.org/download/apache-donation/  - SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message