nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] wonook commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish methods
Date Sat, 07 Sep 2019 10:36:45 GMT
wonook commented on a change in pull request #187: [NEMO-324] Distinguish Beam's run and waitUntilFinish
methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r321964291
 
 

 ##########
 File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
 ##########
 @@ -164,7 +164,8 @@ public final Enum waitUntilJobFinish(final long timeout,
         return stateTranslator.translateState(driverEndpoint.get().
             waitUntilFinish(timeout - unit.convert(consumedTime, TimeUnit.NANOSECONDS), unit));
       } else {
-        return PlanState.State.READY;
+        // This default value needs double checking.
+        return stateTranslator.translateState(PlanState.State.READY);
 
 Review comment:
   By the way this change was made to sync the return type with all other types. This was
the only case where it was PlanState.State, instead of Beam's PipelineResult.State

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message