From notifications-return-746-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Mon Aug 5 04:40:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 40088180181 for ; Mon, 5 Aug 2019 06:40:47 +0200 (CEST) Received: (qmail 94065 invoked by uid 500); 5 Aug 2019 04:40:46 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 94056 invoked by uid 99); 5 Aug 2019 04:40:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Aug 2019 04:40:46 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] hy00nc commented on issue #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer) Message-ID: <156498004654.32300.2122836264725067739.gitbox@gitbox.apache.org> Date: Mon, 05 Aug 2019 04:40:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hy00nc commented on issue #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer) URL: https://github.com/apache/incubator-nemo/pull/223#issuecomment-518083152 > Thanks @hy00nc. > > * Regarding 1: Let's include it this time. I'll take a closer look once a new PR that uses the random access methods comes up. > * Regarding 2: It'd be good to implement this part as you suggested. > > Please let me know when you want me to take a final look at the code and merge. 😄 @johnyangk thanks for the suggestions. I have implemented the reuse mechanism plz refer to this [commit](https://github.com/apache/incubator-nemo/pull/223/commits/43821610d1cdfc5529f51639ad2965ef29cc7a29). It will be a big help if you could review the overall fixes and edits in this PR. Thank you😄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services