From notifications-return-739-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Fri Aug 2 11:23:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 61037180647 for ; Fri, 2 Aug 2019 13:23:05 +0200 (CEST) Received: (qmail 52282 invoked by uid 500); 2 Aug 2019 11:23:04 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 52273 invoked by uid 99); 2 Aug 2019 11:23:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Aug 2019 11:23:04 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] alapha23 edited a comment on issue #227: [NEMO-398] ExecutorRepresenter interface and DefaultExecutorRepresenter Message-ID: <156474498473.27084.11116112619684924942.gitbox@gitbox.apache.org> Date: Fri, 02 Aug 2019 11:23:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alapha23 edited a comment on issue #227: [NEMO-398] ExecutorRepresenter interface and DefaultExecutorRepresenter URL: https://github.com/apache/incubator-nemo/pull/227#issuecomment-517664718 @taegeonum Updated. Removed most use of `DefaultExecutorRepresenter` in tests, and redundant log messages. Note that instantiating an object would still need `DefaultExecutorRepresenter`, for instance [this line](https://github.com/apache/incubator-nemo/pull/227/files#diff-ce86ff9b39e9ec63431f873f5ef46670R105) [JIRA](https://issues.apache.org/jira/browse/NEMO-398) added comments about the design logic with this pr. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services