nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] taegeonum commented on a change in pull request #231: [NEMO-406] Invoke LambdaExecutor without creating containers
Date Mon, 26 Aug 2019 22:12:25 GMT
taegeonum commented on a change in pull request #231: [NEMO-406] Invoke LambdaExecutor without
creating containers
URL: https://github.com/apache/incubator-nemo/pull/231#discussion_r317819308
 
 

 ##########
 File path: client/src/main/java/org/apache/nemo/client/JobLauncher.java
 ##########
 @@ -381,6 +387,39 @@ private static Configuration getDriverConf(final Configuration jobConf)
throws I
       .set(DriverConfiguration.DRIVER_IDENTIFIER, jobId)
       .set(DriverConfiguration.DRIVER_MEMORY, driverMemory)
       .build();
+
+    final JavaConfigurationBuilder jcb = Tang.Factory.getTang().newConfigurationBuilder();
+    jcb.bindSetEntry(DriverIdleSources.class, LambdaIdlenessSource.class);
+
+    return Configurations.merge(configuration, jcb.build());
+  }
+
+  /**
+   * LambdaIdlenessSource is only used when we choose LambdaExecutor.
+   * Without this class, meaning having no Idle source, will cause reef to shut down the
driver directly.
+   * This class makes sure reef shutdown the driver at the correct time specified by lambdaMaster.
+   */
+  public static final class LambdaIdlenessSource implements DriverIdlenessSource {
 
 Review comment:
   Please create a separate class instead of the inner class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message