nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on issue #235: [NEMO-414] Command-line specified runtime data plane configurations not applied
Date Wed, 21 Aug 2019 12:46:25 GMT
hy00nc commented on issue #235: [NEMO-414] Command-line specified runtime data plane configurations
not applied
URL: https://github.com/apache/incubator-nemo/pull/235#issuecomment-523440734
 
 
   > @hy00nc Thanks for the PR! How about creating a wrapper class that contains the executor
variables?
   > e.g.
   > 
   > ```
   > final class ExecutorConf {
   > 
   > @Inject
   > private ExecutorConf(Parameter(JobConf.GlusterVolumeDirectory.class) final String
glusterDirectory, ...) {
   > ...
   > } 
   > 
   > getExecutorConfiguration()
   > 
   > }
   > ```
   
   Thanks for the comment! I created a wrapper class named `DataPlaneConf`.
   To avoid confusion, the existing executor configurations except for the data plane configurations
remain as they were before. It is very tricky to clearly separate the executor configurations
inside NemoDriver.java :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message