nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] alapha23 commented on a change in pull request #231: [NEMO-406] Invoke LambdaExecutor without creating containers
Date Mon, 19 Aug 2019 21:53:39 GMT
alapha23 commented on a change in pull request #231: [NEMO-406] Invoke LambdaExecutor without
creating containers
URL: https://github.com/apache/incubator-nemo/pull/231#discussion_r315428614
 
 

 ##########
 File path: runtime/driver/src/main/java/org/apache/nemo/driver/NemoDriver.java
 ##########
 @@ -149,7 +153,18 @@ private void shutdown() {
     @Override
     public void onNext(final StartTime startTime) {
       setUpLogger();
-      runtimeMaster.requestContainer(resourceSpecificationString);
+      if (executorType.equals("lambda")) {
+        LOG.info("##### lambda executor #####");
+        runtimeMaster.requestLambdaExecutor();
+
+        clientRPC.send(ControlMessage.DriverToClientMessage.newBuilder()
+          .setType(ControlMessage.DriverToClientMessageType.DriverReady).build());
+      } else if (executorType.equals("default")) {
 
 Review comment:
   Same as above.
   What is the benefit if we use static variables?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message