nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
Date Tue, 06 Aug 2019 07:29:33 GMT
hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse
ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r310916704
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/partition/SerializedPartition.java
 ##########
 @@ -226,4 +241,14 @@ public int getLength() throws IOException {
   public boolean isOffheap() {
     return offheap;
   }
+
+  /**
+   * Releases the off-heap memory that this SerializedPartition holds.
+   */
+  public void release() {
 
 Review comment:
   Thanks! I just added one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message