nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on issue #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
Date Mon, 05 Aug 2019 04:40:46 GMT
hy00nc commented on issue #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#issuecomment-518083152
 
 
   > Thanks @hy00nc.
   > 
   > * Regarding 1: Let's include it this time. I'll take a closer look once a new PR that
uses the random access methods comes up.
   > * Regarding 2: It'd be good to implement this part as you suggested.
   > 
   > Please let me know when you want me to take a final look at the code and merge. 😄
   
   @johnyangk thanks for the suggestions. I have implemented the reuse mechanism plz refer
to this [commit](https://github.com/apache/incubator-nemo/pull/223/commits/43821610d1cdfc5529f51639ad2965ef29cc7a29).

   
   It will be a big help if you could review the overall fixes and edits in this PR.  Thank
you😄

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message