From notifications-return-680-archive-asf-public=cust-asf.ponee.io@nemo.apache.org Thu Jul 25 06:25:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 74314180695 for ; Thu, 25 Jul 2019 08:25:27 +0200 (CEST) Received: (qmail 63088 invoked by uid 500); 25 Jul 2019 06:25:26 -0000 Mailing-List: contact notifications-help@nemo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nemo.apache.org Delivered-To: mailing list notifications@nemo.apache.org Received: (qmail 63044 invoked by uid 99); 25 Jul 2019 06:25:26 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jul 2019 06:25:26 +0000 From: GitBox To: notifications@nemo.apache.org Subject: [GitHub] [incubator-nemo] johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer) Message-ID: <156403592679.29865.2942649348155221948.gitbox@gitbox.apache.org> Date: Thu, 25 Jul 2019 06:25:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer) URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307130861 ########## File path: runtime/executor/src/test/java/org/apache/nemo/runtime/executor/data/MemoryChunkTest.java ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.runtime.executor.data; + +import org.apache.commons.lang.ArrayUtils; +import org.junit.Before; +import org.junit.Test; + +import java.nio.ByteBuffer; +import java.util.Random; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; + +/** + * Tests basic operations on {@link MemoryChunk}. + */ +public class MemoryChunkTest { Review comment: I really like this test. I also noticed several unused methods in MemoryChunk, getShort() for example. Can you add tests for those methods as well? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services