nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
Date Sat, 27 Jul 2019 08:07:11 GMT
hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse
ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307957640
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/SerializedMemoryStore.java
 ##########
 @@ -75,6 +79,9 @@ public void writeBlock(final Block block) throws BlockWriteException {
    */
   @Override
   public boolean deleteBlock(final String blockId) {
+    for (Block block: getBlockMap().values()) {
+      block.release();
 
 Review comment:
   That's right I will remove the unnecessary functions. Btw, while going through this file,
I noticed that although `FileBlock` and parts where `NonSerializedPartition` is converted
to `SerializedPartition` use `SerializedPartition` that uses off-heap memory, there is no
releasing of their off-heap memory. I will think more on this part😂

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message