nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
Date Thu, 25 Jul 2019 06:25:24 GMT
johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap memory management
(reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307125637
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/SerializedMemoryStore.java
 ##########
 @@ -75,6 +79,9 @@ public void writeBlock(final Block block) throws BlockWriteException {
    */
   @Override
   public boolean deleteBlock(final String blockId) {
+    for (Block block: getBlockMap().values()) {
+      block.release();
 
 Review comment:
   Keep only SerializedMemoryBlock#release and remove others (i.e., remove release() from
the Block interface). This method is invoked only here. Isn't Block here guaranteed to be
SerializedMemoryBlock?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message