nemo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nemo] hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse ByteBuffer)
Date Wed, 24 Jul 2019 07:55:11 GMT
hy00nc commented on a change in pull request #223: [NEMO-388] Off-heap memory management (reuse
ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r306673588
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/BlockStore.java
 ##########
 @@ -33,13 +34,14 @@
    * A stale data created by previous failed task should be handled during the creation of
new block.
    *
    * @param blockId the ID of the block to create.
+   * @param memoryPoolAssigner  the MemoryPoolAssigner for memory allocation.
    * @return the created block.
    * @throws BlockWriteException for any error occurred while trying to create a block.
    *                             (This exception will be thrown to the scheduler
    *                             through {@link org.apache.nemo.runtime.executor.Executor}
and
    *                             have to be handled by the scheduler with fault tolerance
mechanism.)
    */
-  Block createBlock(String blockId) throws BlockWriteException;
+  Block createBlock(String blockId, MemoryPoolAssigner memoryPoolAssigner) throws BlockWriteException;
 
 Review comment:
   Injecting `MemoryPoolAssigner` directly would be really nice! Just to inform you,  every
`Store` including `LocalFileStore` and `GlusterFileStore` use `MemoryPoolAssigner` while creating
`FileBlock`, since it uses `SerializedPartition` that is by default written in off-heap memory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message